ui-label icon indicating copy to clipboard operation
ui-label copied to clipboard

enableIOSDTCoreText is not a function

Open fpaaske opened this issue 2 years ago • 4 comments

I'd just let you know that we ran into this issue recently. After some debugging it seems like it's probably due to this commit from https://github.com/nativescript-community/text

This bug came to us via a patch release of ui-label, but I think this qualifies as a breaking change (in the text-repo)? That would prevent it from sneaking in unnoticed, I think 😊

Anyway, I see that the feature was removed, so we've adapted the code. Perhaps you could update the documentation?

Thanks for an otherwise excellent plugin! ❤️

fpaaske avatar Aug 02 '23 15:08 fpaaske

@fpaaske sorry about this. I can bring in back if you want but dtcoretext hasn't been updated in a very long time. otherwise I LL update the doc. thanks

farfromrefug avatar Aug 02 '23 15:08 farfromrefug

No worries, and thanks for the quick response! I don't think we need DTCoreText. I don't even know what it's for, except is was recommend for performance some years back.

The plugin seems to work the same without it 👍

fpaaske avatar Aug 02 '23 15:08 fpaaske

ok so you understand dtcoretext was there to parse XML string into NSattributedstring. but now in latest iOS versions iOS do it pretty well. in the beginning dtcoretext was faster but it is not maintained anymore and I dont even think it is faster now. will update the doc

farfromrefug avatar Aug 02 '23 16:08 farfromrefug

That's good to know. I guess the fewer deps the better. Thanks again!

fpaaske avatar Aug 03 '23 05:08 fpaaske