fatfs icon indicating copy to clipboard operation
fatfs copied to clipboard

Published 20 hours ago • verified publisher icon natevw

Add method for creating volume label

Open andrzejressel opened this issue 5 years ago • 5 comments

This PR adds method createLabel that will create special file for volume label that will be detected by blkid after latest changes.

I've tested it with my fork of Xen Orchestra: https://github.com/jereksel/xen-orchestra/tree/label and Ubuntu 20.04

Fixes #30

andrzejressel avatar Jun 13 '20 23:06 andrzejressel

Hi sorry for the delay on this. I think this is a good start and a reasonable approach overall, but have lots of specific feedback I'll add on the PR itself soon. (About to hop on yet another meeting call…)

natevw avatar Jun 30 '20 20:06 natevw

I tested this branch and recompiled XO locally and it didn't work. Is that functional?

marlluslustosa avatar Jul 20 '20 14:07 marlluslustosa

I tested this branch and recompiled XO locally and it didn't work. Is that functional?

Yeah, it should work fine. Could you please provide output of blkid /dev/cdrom and dosfslabel /dev/cdrom. I think you could also try to debug cloud-init. I can't remember how I've done it, but you can invoke only source search.

andrzejressel avatar Jul 21 '20 19:07 andrzejressel

Sorry that it took so long. I've fixed PR all comments

andrzejressel avatar Jul 21 '20 19:07 andrzejressel

Cool. I am currently working to fix this on cloudinit. I have now sent patch patches to cloudinit both to see LABEL and LABEL_FATBOOT in their own scripts.

I hope to see this resolved by both parties as soon as possible. You can check my update here: https://bugs.launchpad.net/cloud-init/+bug/1841466/comments/5 thanks!

marlluslustosa avatar Jul 21 '20 20:07 marlluslustosa

D'oh! Sorry to let this one linger, but thanks for cleaning it up if it's no longer needed.

natevw avatar May 30 '23 22:05 natevw