openmct icon indicating copy to clipboard operation
openmct copied to clipboard

chore: bump `@percy/cli` to 1.29.1 and `@percy/playwright` to 1.0.6

Open ozyx opened this issue 1 year ago • 3 comments

Closes

Describe your changes:

All Submissions:

  • [ ] Have you followed the guidelines in our Contributing document?
  • [ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [ ] Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • [ ] Changes address original issue?
  • [ ] Tests included and/or updated with changes?
  • [ ] Has this been smoke tested?
  • [ ] Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • [ ] Have you associated a milestone with this PR? Note: leave blank if unsure.
  • [ ] Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • [ ] Changes appear to address issue?
  • [ ] Reviewer has tested changes by following the provided instructions?
  • [ ] Changes appear not to be breaking changes?
  • [ ] Appropriate automated tests included?
  • [ ] Code style and in-line documentation are appropriate?

ozyx avatar Aug 14 '24 17:08 ozyx

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.85%. Comparing base (21a4335) to head (ae83486). Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7814      +/-   ##
==========================================
+ Coverage   56.14%   56.85%   +0.71%     
==========================================
  Files         674      674              
  Lines       27283    27283              
  Branches     2669     2669              
==========================================
+ Hits        15317    15511     +194     
+ Misses      11629    11433     -196     
- Partials      337      339       +2     
Flag Coverage Δ
e2e-ci 61.04% <ø> (+5.55%) :arrow_up:
e2e-full 23.52% <ø> (-31.61%) :arrow_down:
unit 49.35% <ø> (-0.20%) :arrow_down:

see 66 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21a4335...ae83486. Read the comment docs.

codecov[bot] avatar Aug 14 '24 17:08 codecov[bot]

@ozyx this was failing some months ago.

unlikelyzero avatar Aug 14 '24 18:08 unlikelyzero

@unlikelyzero looks like it still is for some reason. playwright catching a browser error from percy in visual-a11y tests:

    Error: Console error detected: [error] Failed to load resource: net::ERR_NAME_NOT_RESOLVED at (http://render.percy.local/__serialized__/_ws0muqhxi.png 0:0)

ozyx avatar Aug 14 '24 18:08 ozyx

@ozyx let's close this

unlikelyzero avatar Sep 10 '24 03:09 unlikelyzero

@ozyx let's close this

😔

ozyx avatar Sep 10 '24 03:09 ozyx