openmct icon indicating copy to clipboard operation
openmct copied to clipboard

Ensure time conductor mode is set when synchronizing time range

Open shefalijoshi opened this issue 1 year ago • 5 comments

Closes #7729

Describe your changes:

Use setMode API to set the time span as well as the bounds instead of the old bounds time API.

All Submissions:

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x] Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • [x] Changes address original issue?
  • [x] Tests included and/or updated with changes?
  • [x] Has this been smoke tested?
  • [x] Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • [x] Have you associated a milestone with this PR? Note: leave blank if unsure.
  • [x] Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • [ ] Changes appear to address issue?
  • [ ] Reviewer has tested changes by following the provided instructions?
  • [ ] Changes appear not to be breaking changes?
  • [ ] Appropriate automated tests included?
  • [ ] Code style and in-line documentation are appropriate?

shefalijoshi avatar May 14 '24 17:05 shefalijoshi

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.64%. Comparing base (c354e1c) to head (6bca2b0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7731      +/-   ##
==========================================
- Coverage   56.65%   56.64%   -0.01%     
==========================================
  Files         673      673              
  Lines       27177    27177              
  Branches     2636     2636              
==========================================
- Hits        15396    15395       -1     
- Misses      11450    11451       +1     
  Partials      331      331              
Flag Coverage Δ
e2e-full 23.57% <ø> (ø)
e2e-stable 60.63% <ø> (-0.01%) :arrow_down:
unit 49.25% <0.00%> (ø)
Files Coverage Δ
src/plugins/plot/MctPlot.vue 38.81% <0.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c354e1c...6bca2b0. Read the comment docs.

codecov-commenter avatar May 14 '24 18:05 codecov-commenter

@shefalijoshi we should add a test in the timeconductor suite

unlikelyzero avatar May 14 '24 22:05 unlikelyzero

Tests, please. Nothing should be pushed any more without tests.

akhenry avatar May 21 '24 17:05 akhenry

@shefalijoshi we should add a test in the timeconductor suite

I'll write a test in the plots suite since this is specific to a plots control

shefalijoshi avatar May 21 '24 22:05 shefalijoshi

Test updated.

shefalijoshi avatar May 22 '24 22:05 shefalijoshi

@shefalijoshi , approved but looks like there are lint errors

davetsay avatar May 29 '24 17:05 davetsay