openmct icon indicating copy to clipboard operation
openmct copied to clipboard

[e2e] Update eslint guidelines to disallow page.locator in favor of web-first locators like page.getByRole

Open unlikelyzero opened this issue 1 year ago • 1 comments

Summary

This will be a fairly large undertaking, but the playwright eslint plugin can help us find all examples of page.locator and replace with page.getByRole()

  • [ ] Upgrade to eslint-playwright >1.6.0
  • [ ] Set playwright eslint rule for no-nth-methods and no-raw-locators to required
  • [ ] Skip for the performance/contract tests

unlikelyzero avatar Dec 17 '23 16:12 unlikelyzero

Notable violations:

  • Create Menu injects icon getByRole('menuitem', { name: ' Display Layout' })

unlikelyzero avatar Dec 28 '23 06:12 unlikelyzero