openmct icon indicating copy to clipboard operation
openmct copied to clipboard

Plots in Time Strip are not aligning properly with Plans

Open charlesh88 opened this issue 2 years ago • 4 comments

Summary

In Testathon 7/19/23, when a plot view is in a Time Strip with a Plan, it's not aligning properly with the Plan in time due to the plot's Y axis:

Screen Shot 2023-07-19 at 11 02 58 AM

Expected Behavior

The Time Strip is supposed to include any included plot's Y axes width into its offset calculation:

image

Environment

  • Open MCT Version: 3.0.0 SNAPSHOT
  • Deployment Type: /latest, /testathon
  • OS:
  • Browser:

Impact Check List

  • [x] Data loss or misrepresented data?
  • [ ] Regression? Did this used to work or has it always been broken?
  • [ ] Is there a workaround available?
  • [x] Does this impact a critical component?
  • [ ] Is this just a visual bug with no functional impact?
  • [ ] Does this block the execution of e2e tests?
  • [ ] Does this have an impact on Performance?

charlesh88 avatar Jul 19 '23 18:07 charlesh88

@akhenry to look for older duplicate issue.

charlesh88 avatar Jul 19 '23 22:07 charlesh88

One possible approach to a fix here is: instead of putting the plot axis into the left column in the DOM, first calc the space needed for the widest Y axis space for all plots included in the view, then use that value to offset the left edge of all other views (plans, imagery, etc.) so that everything lines up.

charlesh88 avatar Jul 19 '23 22:07 charlesh88

still critical

unlikelyzero avatar Dec 20 '23 21:12 unlikelyzero

Testathon 2024-05-09: still not fixed. Purple and yellow dashed lines show elements that should be aligned.

Screenshot 2024-05-09 at 2 31 37 PM

charlesh88 avatar May 09 '24 21:05 charlesh88

Testing Instructions: Create a Time Strip with different types of plots, stacked plots, overlay plots with multiple axes and a plan. Make sure that The main view of the plots, plans and time system axis are aligned properly. Try this in Fixed timespan and realtime modes.

For example:

image

shefalijoshi avatar Jun 20 '24 20:06 shefalijoshi

Looks good to me! Verified fixed.

akhenry avatar Oct 02 '24 22:10 akhenry