cFE icon indicating copy to clipboard operation
cFE copied to clipboard

Fix #1422, Replace UT_DisplayPkt() with UtPrintx()

Open thnkslprpt opened this issue 2 years ago • 2 comments

Checklist

Describe the contribution

  • Fixes #1422
    • all instances of UT_DisplayPkt() replaced with UtPrintx()
    • the declaration and definition of UT_DisplayPkt() deleted
    • UT_DisplayPkt() turned into a simple macro that calls UtPrintx() and placed inside deprecation guards

Testing performed GitHub CI actions (incl. Functional tests and Coverage Analysis etc.) all passing successfully.

Tested locally with standard cFS bundle tests - confirmed output text is correctly displayed and identical to before the change (the only difference other than the inclusion of the memory address, is the spacing and that the alphanumeric characters/digits in the hexadecimal output are now capitalized).

Before changes: Screenshot 2023-03-29 12 54 25

After changes: Screenshot 2023-03-29 12 54 19

Expected behavior changes Test log prints now include the memory address along with the data.

System(s) tested on Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64 Debian GNU/Linux 11 (bullseye) Current main branch of cFS.

Contributor Info Avi Weiss @thnkslprpt

thnkslprpt avatar Mar 29 '23 05:03 thnkslprpt

You have successfully added a new CodeQL configuration coding-standard. As part of the setup process, we have scanned this repository and found 1904 existing alerts. Please check the repository Security tab to see all alerts.

You have successfully added a new CodeQL configuration security. As part of the setup process, we have scanned this repository and found 29 existing alerts. Please check the repository Security tab to see all alerts.