CryptoLib icon indicating copy to clipboard operation
CryptoLib copied to clipboard

471 return tm aos structs

Open Donnie-Ice opened this issue 5 months ago • 3 comments
trafficstars

All Submissions:

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • [x] Does your submission pass tests?

Changes to Core Features:

  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?

How do you test these changes?

Donnie-Ice avatar Jun 19 '25 23:06 Donnie-Ice

Codecov Report

:x: Patch coverage is 91.33710% with 46 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 81.35%. Comparing base (3e0ad81) to head (9629093).

Files with missing lines Patch % Lines
src/core/crypto_config.c 3.84% 22 Missing and 3 partials :warning:
src/core/crypto_tc.c 0.00% 3 Missing and 3 partials :warning:
src/core/crypto_tm.c 88.67% 3 Missing and 3 partials :warning:
src/core/crypto_aos.c 91.07% 2 Missing and 3 partials :warning:
src/core/crypto_mc.c 0.00% 1 Missing and 1 partial :warning:
src/core/crypto_user.c 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #472      +/-   ##
==========================================
+ Coverage   81.19%   81.35%   +0.16%     
==========================================
  Files          39       39              
  Lines       12235    12529     +294     
  Branches     1053     1086      +33     
==========================================
+ Hits         9934    10193     +259     
- Misses       1905     1925      +20     
- Partials      396      411      +15     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 19 '25 23:06 codecov-commenter

I pulled the memory leak fixes into this, so the PR is much larger than it should be

Donnie-Ice avatar Jun 19 '25 23:06 Donnie-Ice

After discussion yesterday don't need standalone in this PR since CL is a submodule of NOS. Approved!

dccutrig avatar Jun 24 '25 16:06 dccutrig