bwapy icon indicating copy to clipboard operation
bwapy copied to clipboard

Unify API with mappy?

Open kyleabeauchamp opened this issue 7 years ago • 5 comments

This is a nice project, but it would be really cool if mappy/minimap2 and bwapy happened to share the same python api.

kyleabeauchamp avatar Apr 02 '18 04:04 kyleabeauchamp

I wonder if @lh3 would be interested if the build system, packaging, and API were consistent with mappy.

kyleabeauchamp avatar Apr 02 '18 04:04 kyleabeauchamp

This package uses CFFI for creating the python extension whilst mappy uses cython. Creating and including libbwa.a here was simply the easiest thing to do (rather than listing all the source files in the python extension build). I think switching making the builds equivalent would amount to a rewrite.

The API here was chosen simply to mirror that of bwa mem with minimal fuss, albeit creating python objects. I think @lh3 has done pretty much the same in his mappy.

We had a short-lived minimappy project before @lh3 released his python binding. My understanding is @lh3 considers minimap2 to make bwa mem obsolete.

cjw85 avatar Apr 02 '18 12:04 cjw85

My understanding is @lh3 considers minimap2 to make bwa mem obsolete.

For long reads, minimap2 should be mostly better than bwa-mem. I wouldn't recommend to use bwa for long reads these days. I thought to replace bwa-mem for short reads, too, but it turns out that bwa-mem is still better at relatively noisy Illumina reads, so bwa-mem will stay for short reads.

lh3 avatar Apr 02 '18 13:04 lh3

All sgtm. My only idea was a "standard" set of functions and classes for I'll interoperability.

On Mon, Apr 2, 2018, 6:43 AM Heng Li [email protected] wrote:

My understanding is @lh3 https://github.com/lh3 considers minimap2 to make bwa mem obsolete.

For long reads, minimap2 should be mostly better than bwa-mem. I wouldn't recommend to use bwa for long reads these days. I thought to replace bwa-mem for short reads, too, but it turns out that bwa-mem is still better at relatively noisy Illumina reads, so bwa-mem will stay for short reads.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nanoporetech/bwapy/issues/8#issuecomment-377931759, or mute the thread https://github.com/notifications/unsubscribe-auth/ABz_q_7fUpTMBWo7_CyeSwPavT3ZHAecks5tkisKgaJpZM4TDITB .

kyleabeauchamp avatar Apr 02 '18 15:04 kyleabeauchamp

@lh3 Thanks for your clarifying blogpost.

cjw85 avatar Apr 02 '18 19:04 cjw85