nanoFramework.IoT.Device icon indicating copy to clipboard operation
nanoFramework.IoT.Device copied to clipboard

Adding support for SSD1306 OLED display with 7-pin I2C/SPI V2

Open devdotnetorg opened this issue 3 years ago • 7 comments

The existing code only supports SSD1306 display with 4-pin. But there is a version with 7-pin I2C/SPI. For this version it is necessary to initialize the pin - RES.

Description

Adding support for SSD1306 OLED display with 7-pin I2C/SPI for only I2C.

Description at the link - post (rus).

Motivation and Context

  • Fixes

How Has This Been Tested?

  • VS 2019 Community Edition on Windows 10
  • ESP-WROOM-32

Screenshots

IMAGE_ALT

Types of changes

  • [x] Improvement (non-breaking change that improves a feature, code or algorithm)
  • [ ] Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • [x] New feature (non-breaking change which adds functionality to code)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Config and build (change in the configuration and build system, has no impact on code or features)
  • [x] Dependencies (update dependencies and changes associated, has no impact on code or features)
  • [ ] Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • [x] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • [x] My code follows the code style of this project (only if there are changes in source code).
  • [ ] My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • [x] I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • [ ] I have added new tests to cover my changes.

devdotnetorg avatar Aug 23 '22 23:08 devdotnetorg

@Ellerbach thanks for review the code. I'll fix the code this week.

devdotnetorg avatar Aug 24 '22 22:08 devdotnetorg

Dont forget to add "nanoFramework.Runtime.Events" version="1.10.0" to .nuspec.

networkfusion avatar Aug 25 '22 16:08 networkfusion

@Ellerbach I fixed code.

devdotnetorg avatar Aug 27 '22 02:08 devdotnetorg

You are missing the Version file and the category file.

Ellerbach avatar Aug 27 '22 08:08 Ellerbach

You are missing the Version file and the category file.

@Ellerbach The category.txt and version.json file already exists.

devdotnetorg avatar Aug 27 '22 16:08 devdotnetorg

@Ellerbach I fixed code.

devdotnetorg avatar Aug 28 '22 09:08 devdotnetorg

@Ellerbach Please see the result.

devdotnetorg avatar Aug 29 '22 14:08 devdotnetorg

@devdotnetorg any chance you can get the review comments addressed and merge the upstream branch so this PR can be merged? Thanks!

josesimoes avatar Dec 19 '22 08:12 josesimoes

@josesimoes Yes, I will merge branches

devdotnetorg avatar Dec 20 '22 12:12 devdotnetorg

@josesimoes Merge conflicts resolved

devdotnetorg avatar Dec 22 '22 14:12 devdotnetorg

@devdotnetorg thank you again for your contribution! :pray::smile:

.NET nanoFramework it's all about community involvement and no contribution is too small. We would like to invite you to join the project Contributors list.

Please edit it and add an entry with your GitHub user in the appropriate location (names sorted alphabetically):

  <tr>
    <td><img src="https://github.com/devdotnetorg.png?size=50&" height="50" width="50" ></td>
    <td><a href="https://github.com/devdotnetorg">Anton</a></td>
  </tr>

(feel free to adjust your name, if it's not correct)

nfbot avatar Dec 22 '22 15:12 nfbot