pandarallel icon indicating copy to clipboard operation
pandarallel copied to clipboard

`shm_size_mb` argument of pandarallel.initialize is never used

Open overmode opened this issue 2 years ago • 3 comments

General

  • Operating System: ~
  • Python version: ~
  • Pandas version: ~
  • Pandarallel version: v1.6.4

Acknowledgement

  • [ ] My issue is NOT present when using pandas without alone (without pandarallel)
  • [ ] If I am on Windows, I read the Troubleshooting page before writing a new bug report

Bug description

It seems like the shm_size_mb argument of the initialize is never used

Observed behavior

Do a search in https://github.com/nalepae/pandarallel/blob/master/pandarallel/core.py

Expected behavior

The term should be used somewhere else than in the signature

Minimal but working code sample to ease bug fix for pandarallel team

~

overmode avatar Feb 03 '23 10:02 overmode

The argument has indeed been deprecated, as can be seen here. I guess there is an argument to be made for raising a DeprecationWarning and removing it a few releases from now. I'll try to get around to implementing this change, but I'm a bit busy right now.

till-m avatar Feb 03 '23 10:02 till-m

Nice, thank you ! If I find time, I can push a very basic PR

overmode avatar Feb 03 '23 10:02 overmode

Pandaral·lel is looking for a maintainer! If you are interested, please open an GitHub issue.

nalepae avatar Jan 23 '24 09:01 nalepae