maim icon indicating copy to clipboard operation
maim copied to clipboard

ICU-related warning from CMake

Open kozross opened this issue 7 years ago • 2 comments
trafficstars

Warning text is:

CMake Warning at CMakeLists.txt:105 (find_package):
  By not providing "FindICU.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "ICU", but
  CMake did not find one.

  Could not find a package configuration file provided by "ICU" with any of
  the following names:

    ICUConfig.cmake
    icu-config.cmake

  Add the installation prefix of "ICU" to CMAKE_PREFIX_PATH or set "ICU_DIR"
  to a directory containing one of the above files.  If "ICU" provides a
  separate development package or SDK, be sure it has been installed.

I don't know if it's benign, but it's probably not something you want showing up.

kozross avatar Mar 27 '18 06:03 kozross

Just realized this is an issue with slop, not maim. Sorry about that - please feel free to close or relocate this issue.

kozross avatar Mar 27 '18 06:03 kozross

It's a purposeful warning that means you're compiling without Unicode support for parameters. This matters just a tad due to slop allowing for specifying file names which could require Unicode characters.

I haven't actually tested the Unicode support of slop without ICU, or with it, it's just listed in cxxopt's CMakeLists.txt in order to enable unicode here: https://github.com/jarro2783/cxxopts/blob/76bd60dc17ca514f2febb49382b38d526d5502a5/CMakeLists.txt#L47

naelstrof avatar Jun 13 '18 23:06 naelstrof