Nabil Freij comments

Results 767 comments of


                                            Nabil Freij

Adds `get_contours` and supports "method" key word a keyword argument to select between `contourpy` and `scikit-image`

> Has someone confirmed that the returned contours are in fact identical with this change? Or are the contours similar but not necessarily identical? None of the figure tests changed?...

Adds `get_contours` and supports "method" key word a keyword argument to select between `contourpy` and `scikit-image`

Wait, why?!

Adds `get_contours` and supports "method" key word a keyword argument to select between `contourpy` and `scikit-image`

So we should add a figure test doing the comparison of the two methods?

Adds `get_contours` and supports "method" key word a keyword argument to select between `contourpy` and `scikit-image`

Ah ok, we should change the changelog then!

Adds `get_contours` and supports "method" key word a keyword argument to select between `contourpy` and `scikit-image`

The other choice is to add a method keyword and allow users to select either package? If we want to avoid a breaking change.

Adds `get_contours` and supports "method" key word a keyword argument to select between `contourpy` and `scikit-image`

> > The other choice is to add a method keyword and allow users to select either package? > > If we want to avoid a breaking change. > >...

Adds `get_contours` and supports "method" key word a keyword argument to select between `contourpy` and `scikit-image`

> How can I go about updating figure tests and adding tests in general? Do you mean updating the hashes of the figure tests or creating new ones? For adding...

Adds `get_contours` and supports "method" key word a keyword argument to select between `contourpy` and `scikit-image`

> > Do you mean updating the hashes of the figure tests or creating new ones? > > Both, actually—updating the necessary hashes for this PR and creating new ones....

Adds `get_contours` and supports "method" key word a keyword argument to select between `contourpy` and `scikit-image`

> Any Other Suggestions? Not right now, this needs a second reviewer to approve.

Adds `get_contours` and supports "method" key word a keyword argument to select between `contourpy` and `scikit-image`

> If deprecation is critical, I suggest defining a new method, e.g., `get_contour()`, and then deprecating `contour()`. Oh I like this. We leave the old method alone, deprecate it and...