Nabil Freij comments

Results 778 comments of


                                            Nabil Freij

Consider improving the accuracy of our eclipse calculations

While I appreciate the passion to tackle this issue, unless you are able to understand the process and mathematics behind this, I strongly suggest that no one work on this...

Refactor parsing of time formats to use astropy custom formats

Yes it is.

Refactor parsing of time formats to use astropy custom formats

Go ahead and open a pull request

Refactor parsing of time formats to use astropy custom formats

> Sir, can you please provide me the repo link i am having hard time finding it. This is my first time contributing to open source and i do not...

Refactor parsing of time formats to use astropy custom formats

> Sir, can you please check Check what? Also can you please stop saying sir.

Refactor parsing of time formats to use astropy custom formats

> I have made changes sorry i didn't knew how to push to the main branch of the repo to which i had made the fork currently i am in...

Refactor parsing of time formats to use astropy custom formats

At this point the issue is pretty old, so things have changed in astropy.

Adds `get_contours` and supports "method" key word a keyword argument to select between `contourpy` and `scikit-image`

Do we need to increase our MPL minimum version or are we ok?

Adds `get_contours` and supports "method" key word a keyword argument to select between `contourpy` and `scikit-image`

Can you check the code in draw_contours?

Adds `get_contours` and supports "method" key word a keyword argument to select between `contourpy` and `scikit-image`

> > check the code in draw_contours? > > Can you please elaborate honestly, I don't have more to say. We have a draw_contours method that needs to be looked...