Nabil Freij comments

Results 815 comments of


                                            Nabil Freij

Add limb darkening correction

Extra attempt https://github.com/sunpy/sunpy/pull/3728

Add persistence transform example to the gallery

I believe it comes around every year.

Add persistence transform example to the gallery

@SKKSaikia You don't need permission to work on an issue. Just be aware that there is a PR open (https://github.com/sunpy/sunpy/pull/2455) that deals with part of this issue.

Upcoming major improvements

I would vote for "coords generation" especially with FITS.

Moved ```sunpy.physics.differential_rotation.diff_rot``` to ```sunpy.sun.models.diff_rot```

> Am I supposed to modify anything else? Looks good to me. This will need more reviewers first however before we merge.

Moved ```sunpy.physics.differential_rotation.diff_rot``` to ```sunpy.sun.models.diff_rot```

Oh as long as the tests pass as well. I forgot about those. > Ok great. Maybe I should begin working on another issue. are there any suggestions? I have...

Moved ```sunpy.physics.differential_rotation.diff_rot``` to ```sunpy.sun.models.diff_rot```

> > Oh as long as the tests pass as well. I forgot about those. > > > > > Ok great. Maybe I should begin working on another issue....

Moved ```sunpy.physics.differential_rotation.diff_rot``` to ```sunpy.sun.models.diff_rot```

If you either rebase the changes ontop of the main branch or merge in main instead, hopefully the CI will pass now.

Moved ```sunpy.physics.differential_rotation.diff_rot``` to ```sunpy.sun.models.diff_rot```

> > If you either rebase the changes ontop of the main branch or merge in main instead, hopefully the CI will pass now. > > I rebased but I...

Moved ```sunpy.physics.differential_rotation.diff_rot``` to ```sunpy.sun.models.diff_rot```

I am going to take Alberts changes as an approval of the code changes here.