laravel-modules icon indicating copy to clipboard operation
laravel-modules copied to clipboard

Update return type and type hints

Open dcblogdev opened this issue 1 year ago • 3 comments

dcblogdev avatar Apr 07 '24 22:04 dcblogdev

image

There are a few bugs that require attention.

For instance, the property in src/Activators/FileActivator.php, along with several others, has been identified as having two data types, both of which are formatted incorrectly.

Actual:

    /**
     * Laravel Filesystem instance
     *
     * @var Filesystem
    */
    private mixed $files;

Correction:

    /**
     * Laravel Filesystem instance
    */
    private mixed $files;

Contrary to my previous interaction, not all properties and methods are of mixed types; rather, they each have a specific, precise type.

solomon-ochepa avatar Apr 25 '24 11:04 solomon-ochepa

I was hoping to assist with this; fortunately, you're already on it. The codebase requires some cleanup.

solomon-ochepa avatar Apr 25 '24 11:04 solomon-ochepa

Yeah this is very much a wip not everything is correct yet

dcblogdev avatar Apr 25 '24 11:04 dcblogdev