eslint-plugin-node icon indicating copy to clipboard operation
eslint-plugin-node copied to clipboard

Published 20 hours ago • verified publisher icon mysticatea

Rule `node/no-unpublished-import` should not be enabled for private packages

Open josokinas opened this issue 8 years ago • 8 comments

If package.json file has "private" set to true, it will restrict the package from being published to the registry. Therefor having node/no-unpublished-import rule enabled does not make sense.

josokinas avatar Apr 09 '17 21:04 josokinas

I agree, and the same observation applies to node/no-unpublished-require. Happy to make a PR if this should be addressed ;)

ClementParis016 avatar May 11 '17 10:05 ClementParis016

Is this still in discussion ?

pranshu-07 avatar Sep 15 '17 11:09 pranshu-07

At least, I'm using those rules for private packages as well.

mysticatea avatar Sep 16 '17 08:09 mysticatea

Could be an option instead?

edg2s avatar May 24 '20 14:05 edg2s

It is so obvious to me that I can't wait when this will be done. @mysticatea can you show examples of mistakes that you want to prevent with this rule in a private package?

constgen avatar Feb 08 '21 19:02 constgen

Can we merge this in yet? Has been 5 years since this was opened?

uhrohraggy avatar Apr 25 '22 00:04 uhrohraggy

can this issue be closed now?

angelayanpan avatar Dec 20 '22 16:12 angelayanpan

It has been merged into the maintained for, eslint-plugin-n: https://github.com/eslint-community/eslint-plugin-n/pull/57

voxpelli avatar Aug 13 '23 13:08 voxpelli