node icon indicating copy to clipboard operation
node copied to clipboard

Data race #4

Open Zensey opened this issue 1 year ago • 2 comments

Resolves: https://github.com/mysteriumnetwork/node/issues/6060

Note:

github.com/mysteriumnetwork/node/core/service.(*Instance).proposalWithCurrentLocation() github.com/mysteriumnetwork/node/tequilapi/endpoints.(*ServiceEndpoint).toServiceInfoResponse()

The 2 methods, which trigger a race are not public and are in different packages, that's why making a unit-test is not possible.

Zensey avatar Jul 29 '24 13:07 Zensey

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 28.47%. Comparing base (3174272) to head (aef5b00). :warning: Report is 133 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6069      +/-   ##
==========================================
- Coverage   37.92%   28.47%   -9.46%     
==========================================
  Files         371      520     +149     
  Lines       20715    29963    +9248     
==========================================
+ Hits         7856     8531     +675     
- Misses      12075    20607    +8532     
- Partials      784      825      +41     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Jul 29 '24 13:07 codecov-commenter

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 15 '24 04:08 stale[bot]