node icon indicating copy to clipboard operation
node copied to clipboard

Make services' activity status saving more consistent

Open Zensey opened this issue 1 year ago • 2 comments

Context: Very often, when the node is restarted, the activity of services is deactivated in an arbitrary manner. The reason is onordered and concurrent run of updateActiveServicesInUserConfig method on start of each service.

This patch orders run of updateActiveServicesInUserConfig, so that active-services property with all active servies will be written the last.

Fixes: https://github.com/mysteriumnetwork/node/issues/6055

Zensey avatar Jul 23 '24 08:07 Zensey

Codecov Report

:x: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 28.50%. Comparing base (3174272) to head (e4d497a). :warning: Report is 133 commits behind head on master.

Files with missing lines Patch % Lines
tequilapi/endpoints/service.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6066      +/-   ##
==========================================
- Coverage   37.92%   28.50%   -9.43%     
==========================================
  Files         371      520     +149     
  Lines       20715    29963    +9248     
==========================================
+ Hits         7856     8540     +684     
- Misses      12075    20598    +8523     
- Partials      784      825      +41     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Jul 23 '24 08:07 codecov-commenter

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 15 '24 04:08 stale[bot]