MeloTTS icon indicating copy to clipboard operation
MeloTTS copied to clipboard

Published 20 hours ago • verified publisher icon myshell-ai

Fix mecab-python3 version

Open polm opened this issue 1 year ago • 3 comments
trafficstars

Hello, I am the maintainer of mecab-python3. Users of your library have been opening issues at my repo because they have trouble building MeCab. They should not have to build MeCab, but MeloTTS is using an old version of mecab-python3 that doesn't support recent Python versions. This raises the version. There are no functionality changes.

polm avatar Jun 30 '24 14:06 polm

This also removes the double entry noted in #150.

polm avatar Jun 30 '24 14:06 polm

One of our repo is also receiving issues related to this. thanks @polm for providing the patch. ref: https://github.com/bolna-ai/bolna/issues/305

prateeksachan avatar Jul 03 '24 23:07 prateeksachan

Also see #51 - mecab-python3 should be optional in this library, since not everyone is using Japanese.

polm avatar Jul 04 '24 02:07 polm

It looks like the current version is on 1.0.9. Can we close this PR?

YasharF avatar Apr 23 '25 22:04 YasharF

Fine by me. I haven't had any contact from MeloTTS users in a long time.

Looking at the current requirements, I would note that fugashi should be removed, since it seems you're not using it. It's another library I maintain that provides largely the same features as mecab-python3, so it's very unusual to have both of them in one application.

polm avatar Apr 24 '25 03:04 polm