mybatis-dynamic-sql
mybatis-dynamic-sql copied to clipboard
Upgrade handbrake-js to use the latest version of HandbrakeCLI
We should upgrade handbrake-js to use the latest HandbrakeCLI.
Since we're upgrading from HandbrakeCLI v1.3 to v1.5 there will be a high risk of breaking changes, so this update will be released in a new major version of handbrake-js.
To implement:
- [ ] Update this version number to the latest available.
- [ ] Check you have deleted your local
./bin/HandbrakeCLI. - [ ] Run
./script/install.jsto download and install the latest HandbrakeCLI - [ ] Run
npm testand do some test encodes locally. - [ ] Submit PR
I've been using the v1.5.1 for a couple of encodes lately, nothing out of the ordinary, basic functionality of the spawn, run and exec all see to work as expected thus far...
Mostly used to convert using a preset import file, I did have issues with the HandbrakeCLIPath, I have made a pull request #74 to address the issue I had, feel free to review it, and\or deny it.
Just some 2 cent commentary.