mwinkens

Results 41 comments of mwinkens

Waiting for feedback :partying_face:

@nickvergessen Thanks for your review, I implemented everything! I tested this feature again manually, and everything (new) was working as expected

> What about the two points from the description: > > * Add button to schedule deletion for existing announcements > > * Add publish button for unannounced announcements >...

Hello @nickvergessen, are you okay with these changes?

> you want to change to that? I think it'd be better Maybe we should use https://www.php.net/manual/en/function.json-encode.php here, what do you think @nickvergessen ?

@nickvergessen I finished everything on your list and opened an issue for the followup. I also reset the package files, however I'd like you to know, that for the next...

as a workaround you might use the rest api here and post at `/api/v1/announcements`, but you'll need an admin session. But I agree, a CLI would be nice, I'll check...

@nickvergessen this is also ready for review and if you want we can integrate this into the next update! ~400 lines of this ~800 lines PR are just unit tests,...

@nickvergessen ready for review again :tada:

Now, that we have a background job running due to #767, we could add an option/setting for maximum announcement age, check daily for old announcements and archive them