Moritz Warning

Results 434 comments of Moritz Warning

@bluewavenet I haven't tested it yet - but don't have authenticated users already access to the router?

I would need to get back into understanding the iptables setup of NDS in order to review this properly. @bluewavenet do you have an overview?

yes and yes :-)

@wanxewoj you ca use "ip neigh" to get the neighbour table. Add `-4` or `-6` if you want to have IPv4/IPv6 only.

We currently parse text output anyway; it's not very efficient nor very stable. But it adds no dependencies and is easy to do. Also, future developers have it easier to...

grep and awk is on every OpenWrt system. But it is probably much faster to search for the string in C. grep and awk start entire new processes. Here is...

That should do.. ```C int get_mac(char mac[18], const char req_ip[]) { char line[255] = {0}; char ip[64]; FILE *stream; int len; int ret; ret = 0; len = strlen(req_ip); if...

Applied: https://github.com/nodogsplash/nodogsplash/commit/53d5b16b1d30bebea16291599f2826033dc8d147

You are correct regarding inet_ntop and INET6_ADDRSTRLEN+1. Please make two pull requests and reap the karma. :-)

How about we rename `config->gw_address` to `config->gw_ip` and use `config->gw_address` to denote ip + port: ``` config->gw_address = "1.2.3.4:80" config->gw_ip = "1.2.3.4" config->gw_port = 80 ``` Then we can use:...