vue3-realworld-example-app
vue3-realworld-example-app copied to clipboard
Minor enhancements
As I was reading through the source code, I've listed some minor issues which may improve the project:
- Route guards (Currently we can move to the login page by typing the address in the URL bar even when we are already logged in)
mapValidationResponsedoes not handle403error- No need to write
<template #default>for suspense - Enforce an import order convention
- Reset errors when re-submitting the forms
useArticlescomposable: 6.1. InfetchArticlesfunction, sincearticleTypecan only have one value, it's better to useif-elserather than onlyifto skip other checks. 6.2getArticlesMetafunction is acting like a composable. So maybe it's better to rename it touseArticlesMeta- Vue docs doesn't recommend using generic argument for
reactive(). So it may be better to change current generic usage. - In
AppLinkcomponent,useAttrsandv-bind="attrs"can be removed because of Fallthrough Attributes - Add "Not Found" page
I would like to help fix these issues if they are valid to you. :D
Your attentiveness is admirable!
Some of the content of this repository may seem less appropriate with Vue's update, and some of your suggestions are fine. My focus is not on Vue for the time being, if you can, PR welcome!
- In AppLink component, useAttrs and v-bind="attrs" can be removed because of Fallthrough Attributes
~I think it is not a good idea to do this. This will lose the type of the component props. If IDE or VLS can deduce the type of the component's root element, I think it makes sense to do so, and until then, I don't think it's good practice.~
I got it wrong :p