kube-plex icon indicating copy to clipboard operation
kube-plex copied to clipboard

Turn the ClaimToken into a K8s Secret

Open mellena1 opened this issue 6 years ago • 3 comments

Great chart/tool, thanks for making this!

I use a GitOps approach for my cluster deployments, and didn't want to commit the claimToken in plain text to a git repo. So I decided to break it out into a secret!

This PR will allow the end user to specify either the name of an existing secret or still pass the plain text version and the secret will be made for them.

Feel free to make any suggestions and I can make changes or you can make any necessary changes yourself.

mellena1 avatar Oct 11 '19 02:10 mellena1

@mellena1 this is a good PR, and it's good to have more options.

As an aside, if you are using gitops (I am too), take a look at the vault-secrets-operator which will persist secrets from a vault instance.

I use this for the plex claim token in my setup, here:

billimek avatar Oct 11 '19 02:10 billimek

Hmm interesting. I'll have to check it out. I've been using the sealed-secrets project for a while now. I'll have to see if it's worth switching over.

mellena1 avatar Oct 12 '19 00:10 mellena1

The claim is only good for 4 minutes. Why are you saving it anyway? I'm just curious, but it seems like this should be passed on the command line or in the call or whatever.

denebeim avatar Nov 06 '19 16:11 denebeim