Munish Chouhan

Results 273 comments of Munish Chouhan
trafficstars

> This [edab8b7](https://github.com/seqeralabs/wave/pull/818/commits/edab8b7574db020206520d398f5a6c8f2ab77bba) should solve moved the check to a upper method because scan can be requested without build

tested scan mode: ``` % wave -i ubuntu --scan-mode required --wave-endpoint http://localhost:9090 Wave invalid response: [501] {"message":"Security scan service is not enabled - Check Wave configuration setting 'wave.scan.enabled' - HTTP...

> @munishchouhan Let's make a pre-release version and deploy to stage lite + postgres?

@pditommaso there is one issue in lite is that it still required build-workspace to run because of this method in scanconfig https://github.com/seqeralabs/wave/blob/ac81a5793c0887676a1c9ffc08e423ca67294cc8/src/main/groovy/io/seqera/wave/configuration/ScanConfig.groovy#L114 Should we move it to ContainerScanServiceImpl?

> @pditommaso there is one issue in lite is that it still required build-workspace to run because of this method in scanconfig > > https://github.com/seqeralabs/wave/blob/ac81a5793c0887676a1c9ffc08e423ca67294cc8/src/main/groovy/io/seqera/wave/configuration/ScanConfig.groovy#L114 > > Should we move...

Tested: ``` (base) munish.chouhan@Munishs-MacBook-Pro ~ % wave -i ubuntu --wave-endpoint https://wave.eu.ngrok.io wave.eu.ngrok.io/wt/aab7725fa1e7/library/ubuntu:latest (base) munish.chouhan@Munishs-MacBook-Pro ~ % docker pull wave.eu.ngrok.io/wt/aab7725fa1e7/library/ubuntu:latest latest: Pulling from wt/aab7725fa1e7/library/ubuntu 2f074dc76c5d: Pull complete Digest: sha256:6015f66923d7afbc53558d7ccffd325d43b4e249f41a6e93eef074c9505d2233 Status: Downloaded...

tested in local machine ``` (base) munish.chouhan@Munishs-MacBook-Pro ~ % wave -i ubuntu --config-file https://fusionfs.seqera.io/releases/v2.4.13-arm64.json --wave-endpoint http://localhost:9090 334e-84-127-154-163.ngrok-free.app/wt/b56717475bcc/library/ubuntu:latest (base) munish.chouhan@Munishs-MacBook-Pro ~ % docker pull 334e-84-127-154-163.ngrok-free.app/wt/b56717475bcc/library/ubuntu:latest latest: Pulling from wt/b56717475bcc/library/ubuntu 69c262fc30fc: Pull...

> Good or bad? Good, I am making one more test with docker compose will report the results soon

tested successfully with docker compose ``` wave-1 | 11:15:34.089 [main] INFO i.m.c.DefaultApplicationContext$BootstrapEnvironment - Established active environments: [lite, rate-limit, redis, postgres, prometheus] >> wt= wave-1 | 11:15:34.640 [main] INFO i.m.context.DefaultBeanContext -...