contrib
contrib copied to clipboard
kvm plugins improvements
I added a few improvements to the kvm plugins:
- Make most of them also work on RedHat based systems
- Add an additional kvm_net_rh Plugin that works on RedHat bases systems. It is more or less a copy of the existing kvm_net plugin, which does not work and which needed to many changes which I'm not sure would have broken things further.
Closing and opening old pull request, to have it tested by travis-ci.
@duritong: are you still interested in this pull request? What do you think about the issues above?
So I reworked the whole stuff and I hope problems to be solved by now
Regarding the RH specific plugin: I have only rhel based kvm boxes and there were some significant differences, I wasn't able to test on debian based kvm boxes. So either someone needs to test it or we should keep it as seperate plugins.
I agree though, that a unified plugin would be better, but given I don't have access to debian based kvm boxes I can't really verify my changes.
I would be happy, if you could change the bits necessary for your environment and also fix/improve more details along the way (in separate commits). Most of the plugins do not have a fixed maintainer and cannot be easily tested by the repository maintainers - thus it is usually highly welcome to combine fixes with general cleanups.
Regarding Debian/Red Hat: I have access to Debian systems with kvm and I am fluent in python. Thus I would be happy to test and fix (if necessary) the plugins, as soon as you included the Red Hat specific parts.
@duritong: what do you think?
I'll try to work on it, december was a bit a busy month for me.
@duritong: just a friendly (and patient) reminder ...
@duritong: ping?
Ping?
Stale pull request message