mx-chain-go icon indicating copy to clipboard operation
mx-chain-go copied to clipboard

TrieRecreate refactor

Open BeniaminDrasovean opened this issue 1 year ago • 1 comments

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

BeniaminDrasovean avatar Mar 06 '24 09:03 BeniaminDrasovean

Codecov Report

Attention: Patch coverage is 68.18182% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 78.74%. Comparing base (c3383ee) to head (de374b5). Report is 61 commits behind head on rc/v1.7.next1.

:exclamation: Current head de374b5 differs from pull request most recent head f9ee246. Consider uploading reports for the commit f9ee246 to get more accurate results

Files Patch % Lines
common/holders/rootHashHolder.go 20.00% 4 Missing :warning:
genesis/process/metaGenesisBlockCreator.go 0.00% 2 Missing :warning:
genesis/process/shardGenesisBlockCreator.go 0.00% 2 Missing :warning:
process/peer/process.go 0.00% 2 Missing :warning:
state/accountsDB.go 84.61% 2 Missing :warning:
state/syncer/baseAccountsSyncer.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@                Coverage Diff                @@
##           rc/v1.7.next1    #6018      +/-   ##
=================================================
- Coverage          78.83%   78.74%   -0.10%     
=================================================
  Files                752      752              
  Lines              98254    97976     -278     
=================================================
- Hits               77461    77153     -308     
- Misses             15559    15584      +25     
- Partials            5234     5239       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 06 '24 10:03 codecov[bot]