mx-chain-go icon indicating copy to clipboard operation
mx-chain-go copied to clipboard

Feat/hardfork exclusion handler

Open sstanculeanu opened this issue 3 years ago • 1 comments

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

sstanculeanu avatar Dec 02 '22 22:12 sstanculeanu

Codecov Report

Patch coverage: 97.60% and project coverage change: -0.03 :warning:

Comparison is base (723c557) 79.01% compared to head (43e1dd1) 78.99%.

:exclamation: Current head 43e1dd1 differs from pull request most recent head e60de9d. Consider uploading reports for the commit e60de9d to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.6.0    #4756      +/-   ##
=============================================
- Coverage      79.01%   78.99%   -0.03%     
=============================================
  Files            680      681       +1     
  Lines          88018    88107      +89     
=============================================
+ Hits           69550    69602      +52     
- Misses         13259    13295      +36     
- Partials        5209     5210       +1     
Impacted Files Coverage Δ
common/hardfork/hardforkExclusionHandler.go 83.33% <83.33%> (ø)
factory/processing/processComponents.go 65.53% <93.93%> (+<0.01%) :arrow_up:
node/nodeRunner.go 74.14% <97.26%> (-2.81%) :arrow_down:
consensus/spos/bls/blsSubroundsFactory.go 91.48% <100.00%> (+0.23%) :arrow_up:
consensus/spos/bls/subroundStartRound.go 69.45% <100.00%> (+1.09%) :arrow_up:
consensus/spos/sposFactory/sposFactory.go 100.00% <100.00%> (ø)
epochStart/bootstrap/common.go 100.00% <100.00%> (ø)
epochStart/bootstrap/process.go 84.82% <100.00%> (+0.03%) :arrow_up:
factory/bootstrap/bootstrapComponents.go 91.97% <100.00%> (+0.08%) :arrow_up:
factory/consensus/consensusComponents.go 96.65% <100.00%> (+0.02%) :arrow_up:
... and 7 more

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Jan 03 '23 08:01 codecov-commenter