Jonathan Ballet

Results 91 comments of Jonathan Ballet

That would be a great addition to add, yes! The canonical documentation for this would be: * https://cloud.google.com/logging/docs/structured-logging#structured_logging_special_fields for the `httpRequest` field * https://cloud.google.com/logging/docs/reference/v2/rest/v2/LogEntry#httprequest for the fields it supports, and...

I've started to draft a solution in https://github.com/multani/structlog-gcp/pull/46

@fsdrw08 have you tried to report these issues upstream by any chance?

@roryschadler sorry for the delay ; would you be able to extend the test suite to show the bug and your change fixes it?

Yes, this folder would be a good place. The test file you already updated should contain some serialization tests already, maybe it could be a good place to extend with...

@roryschadler thanks for the tests, I will take a look. In the meantime, can you regenerate the sample files using the commands in the first message of the PR and...

I did a basic check if the fix was working and it seems so. I'm really not familiar with the multipart code, @wing328 if you want to take another look,...

Releasing the Python version to >= 3.8 pulls in a newer version of aiohttp, which triggers this bug: https://github.com/aio-libs/aiohttp/issues/8555

cc @cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)

@wing328 when you have time, could you check this out?