pfctl-rs icon indicating copy to clipboard operation
pfctl-rs copied to clipboard

Published 20 hours ago • verified publisher icon mullvad

Add github actions CI and remove travis CI

Open faern opened this issue 1 year ago • 3 comments
trafficstars

The CI for this crate has not been running for a looong time. We have not used Travis for years.

This change is Reviewable

faern avatar May 03 '24 06:05 faern

Note that running tests on macOS require root, since we access /usr/bin/pf. Alternatively we could feature-gate integration tests, but of course it would be beneficial to have them running as a part of CI.

pronebird avatar May 03 '24 08:05 pronebird

In this case the tests can't even be built. Look at the errors. My guess is that pfvar.rs must be re-generated with a newer version of bindgen or something.

faern avatar May 03 '24 12:05 faern

In this case the tests can't even be built. Look at the errors. My guess is that pfvar.rs must be re-generated with a newer version of bindgen or something.

Yes either rebuild bindings with new bindgen or pick it up from https://github.com/mullvad/pfctl-rs/pull/87 where I had also updated pfvar.h with the most recent.

pronebird avatar May 03 '24 13:05 pronebird