FileCheck.py

FileCheck.py copied to clipboard

Double-check how escaping strings works for regex-based CHECKs

1

``` /sandbox/build/build.mull.dir/tools/driver-cxx/mull-cxx -version + /Users/Stanislaw/workspace/code/FileCheck.py/tests/integration/tools/FileCheck/FileCheck /sandbox/mull/tests-lit/tests/tutorials/hello-world/step-1-version/sample.cpp --strict-whitespace --match-full-lines /sandbox/mull/tests-lit/tests/tutorials/hello-world/step-1-version/sample.cpp:5:9: error: CHECK: expected string not found in input ; CHECK:{{^Version: \d+\.\d+.\d+$}} ^ :3:1: note: scanning from here Version: 0.6.1 ^ ```

stanislaw

``` FileCheck.py/tests/integration/tests/real_world_samples/mull/02-weird-scanning-from-here-location/sample.itest:5:9: error: found start of regex string with no end '}}' ; CHECK:{{^ ^ ^ + test 74 = 1 ```

stanislaw

LLVM's FileCheck seems to disable the "note: possible intended match here" output in the situations where it is perfectly fine to show this suggestion.

stanislaw

Feature: "error: CHECK-NEXT: is on the same line as previous match"

2

This has to be implemented. See also: https://reviews.llvm.org/D28896.

stanislaw

"note: possible intended match here" feature needs revision

1

``` Stanislaw@home:filecheck.py (develop)*$ echo "What is FileCheck" | ./tests/integration/tools/FileCheck/FileCheck examples/hello-world.check /Users/Stanislaw/sandbox/code/filecheck.py/tests/integration/tools/FileCheck examples/hello-world.check:1:10: error: CHECK: expected string not found in input ; CHECK: Hello world ^ :1:1: note: scanning from here...

stanislaw