mui-x
mui-x copied to clipboard
mui
[core] Various TS improvements
The base goal was to merge https://github.com/mui/mui-x/pull/4640 but it's not doable for now (see https://github.com/mui/mui-x/pull/4640#issuecomment-1191266130)
The TS improvements are worth keeping I think
These are the results for the performance tests:
| Test case | Unit | Min | Max | Median | Mean | σ |
|---|---|---|---|---|---|---|
| Filter 100k rows | ms | 335.5 | 576 | 497.4 | 469.56 | 100.901 |
| Sort 100k rows | ms | 495.4 | 1,024.2 | 714.3 | 752.62 | 170.967 |
| Select 100k rows | ms | 147.3 | 270.6 | 215.3 | 208.92 | 47.062 |
| Deselect 100k rows | ms | 122.7 | 353.7 | 196.4 | 218.62 | 82.88 |
Generated by :no_entry_sign: dangerJS against 1a2f31f748859c4edb99382aff00b87752be680a
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has conflicts, please resolve those before we can evaluate the pull request.
@flaviendelangle I can upgrade @types/react and commit to this PR (since we already migrated to React 18 for the docs). What do you think?
@flaviendelangle I can upgrade @types/react and commit to this PR (since we already migrated to React 18 for the docs). What do you think?
Indeed
If the types are passing (or if there are just a few issues left) let's upgrade