mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[TreeView] Support item reordering using drag and drop

Open flaviendelangle opened this issue 1 year ago • 25 comments
trafficstars

Doc preview Closes #9686

Requirements for this PR

  • #12226
  • #12240
  • #12610
  • #13126
  • #13225

Basic example

  1. Enable the indentationAtItemLevel experimental feature (see #13126)
  2. Pass the itemsReordering prop
<RichTreeViewPro
    items={ITEMS}
    itemsReordering
    experimentalFeatures={{ indentationAtItemLevel: true }}
/>

Current status

  • [x] Support on TreeItem
  • [x] Support on TreeItem2
  • [x] Write doc
  • [x] Write tests

flaviendelangle avatar Feb 26 '24 13:02 flaviendelangle

Deploy preview: https://deploy-preview-12213--material-ui-x.netlify.app/

Updated pages:

Generated by :no_entry_sign: dangerJS against 39cacc41776580e3f656aa67d5f89d51179fc0cb

mui-bot avatar Feb 26 '24 13:02 mui-bot

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 28 '24 12:02 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Mar 04 '24 07:03 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Mar 06 '24 09:03 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Mar 11 '24 08:03 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Mar 25 '24 13:03 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Mar 28 '24 09:03 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 03 '24 14:04 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 03 '24 15:04 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 08 '24 12:04 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 08 '24 17:04 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 09 '24 09:04 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 10 '24 15:04 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 11 '24 06:04 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 11 '24 07:04 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 11 '24 10:04 github-actions[bot]

Cheering for you, brother. Let's get this in!

頑張れ!

benedictchen avatar Apr 21 '24 02:04 benedictchen

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 07 '24 06:05 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 23 '24 17:05 github-actions[bot]

Opened for review

flaviendelangle avatar May 28 '24 13:05 flaviendelangle

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 30 '24 13:05 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 10 '24 07:06 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 12 '24 12:06 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 19 '24 06:06 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 25 '24 14:06 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 02 '24 09:07 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 11 '24 12:07 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 16 '24 12:07 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 22 '24 12:07 github-actions[bot]

I opened a PR for the env check because it's trivial to fix and doing it before the release is better

For the rest we can do a follow up

I believe that clicking Esc should cancel the dragging and releasing the mouse afterwards should not finish it.

Fully agree, I'll fix that

It would be nice to avoid the animation of the dragging item returning (floating) to the original place before finishing the dragging action.

Could you record your screen with this behavior visible to be sure I'm understand what you are referring to?

flaviendelangle avatar Aug 01 '24 15:08 flaviendelangle