material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[Autocomplete] renderInput is using an old api

Open svidskiy opened this issue 1 year ago • 1 comments

Steps to reproduce

The props passed through renderInput use the old API InputProps and InputLabelProps.

image image

Current behavior

No response

Expected behavior

No response

Context

No response

Your environment

System: OS: Windows 11 10.0.22621 Binaries: Node: 20.17.0 - C:\Program Files\nodejs\node.EXE npm: 9.8.1 - C:\Program Files\nodejs\npm.CMD pnpm: 9.9.0 - C:\Program Files\nodejs\pnpm.CMD Browsers: Chrome: Not Found Edge: Chromium (127.0.2651.74) npmPackages: @emotion/react: ^11.11.4 => 11.13.3 @emotion/styled: ^11.11.5 => 11.13.0 @mui/icons-material: ^6.1.3 => 6.1.3 @mui/lab: 6.0.0-beta.11 => 6.0.0-beta.11 @mui/material: ^6.1.3 => 6.1.3 @mui/material-nextjs: ^6.1.3 => 6.1.3 @mui/styled-engine-sc: ^6.1.3 => 6.1.3 @mui/system: ^6.1.3 => 6.1.3 @mui/utils: ^6.1.3 => 6.1.3 @mui/x-data-grid-pro: ^7.20.0 => 7.20.0 @mui/x-date-pickers: ^7.20.0 => 7.20.0 @mui/x-date-pickers-pro: ^7.20.0 => 7.20.0 @mui/x-license: ^7.20.0 => 7.20.0 @types/react: ^18.2.66 => 18.3.5 react: ^18.2.0 => 18.3.1 react-dom: ^18.2.0 => 18.3.1 typescript: ^5.2.2 => 5.5.4

Search keywords: autocomplete, api

svidskiy avatar Oct 17 '24 16:10 svidskiy

It makes sense to be consistent and move the InputProps, inputProps and InputLabelProps into a slotProps key in the options object, but this would be a breaking change. As a first step we could provide both APIs and deprecate the current ones, with the thought of removing them in a future major release.

mnajdova avatar Oct 18 '24 08:10 mnajdova

@sai6855 would https://github.com/mui/material-ui/pull/43606 also address this issue?

mj12albert avatar Oct 24 '24 05:10 mj12albert