material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[test][material-ui] Add tests for Pigment Grid and Stack

Open DiegoAndai opened this issue 1 year ago • 2 comments

While reviewing https://github.com/mui/material-ui/issues/44042 I noticed we didn't have tests for these components. This PR adds them.

DiegoAndai avatar Oct 16 '24 15:10 DiegoAndai

Netlify deploy preview

https://deploy-preview-44132--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad) No bundle size changes

Generated by :no_entry_sign: dangerJS against 1b80bee3c83e7af9c4870a7d7185f5e9963bc0c0

mui-bot avatar Oct 16 '24 15:10 mui-bot

I guess the next step (in the future) will be to move those to be demos on the docs. This way, we can see them in Netlify, Argos can take visual screenshots, etc.

oliviertassinari avatar Oct 16 '24 16:10 oliviertassinari

I guess the next step (in the future) will be to move those to be demos on the docs. This way, we can see them in Netlify, Argos can take visual screenshots, etc.

@oliviertassinari we already have set up screenshot tests for Pigment CSS, it's using the fixtures directory from the vite app, check https://app.argos-ci.com/mui/material-ui/builds/32947/114088289

The main reason why I decided to use the vite app is because Pigment CSS is not used on the docs yet. We are anyway creating the whole docs page so all demos are duplicated & covered, but taken in one screenshot.

mnajdova avatar Oct 22 '24 09:10 mnajdova