material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

Published 20 hours ago • verified publisher icon mui

[Slider][Base] Convert Slider Base to typescript

Open sai6855 opened this issue 2 years ago • 1 comments

Fixes: https://github.com/mui/material-ui/issues/34720

sai6855 avatar Dec 11 '22 12:12 sai6855

Messages
:book: Netlify deploy preview: https://deploy-preview-35445--material-ui.netlify.app/

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 16a378e13da3e358f3dd1378c9ca7b30e39bc21a

mui-bot avatar Dec 11 '22 12:12 mui-bot

@ZeeshanTamboli can you or anyone from team finish review of the PR. previous review came close to being approved

sai6855 avatar Dec 20 '22 05:12 sai6855

@ZeeshanTamboli updated comments and thanks for review

sai6855 avatar Dec 21 '22 11:12 sai6855

@sai6855 I just found two more improvements. Once you resolve them, I will re-approve. Thanks.

ZeeshanTamboli avatar Dec 22 '22 07:12 ZeeshanTamboli

@ZeeshanTamboli updated code as suggested

sai6855 avatar Dec 22 '22 07:12 sai6855

Make sure to update with latest master now that https://github.com/mui/material-ui/pull/35564 was merged.

mnajdova avatar Dec 23 '22 09:12 mnajdova

@mnajdova can this be merged, as everything looks good?

sai6855 avatar Jan 09 '23 08:01 sai6855