material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[examples] Fix remix example

Open secretshardul opened this issue 3 years ago • 4 comments

The IDE complained about imports. Fixed by updated imports from remix to @remix-run/react.

secretshardul avatar Sep 21 '22 06:09 secretshardul

No bundle size changes

Generated by :no_entry_sign: dangerJS against 5d740d1f0bf20c7c3c6dcccb40ed510dac4e66fc

mui-bot avatar Sep 21 '22 06:09 mui-bot

Made the changes

secretshardul avatar Sep 21 '22 09:09 secretshardul

@oliviertassinari can we use your example in Remix's github repo?

https://github.com/remix-run/examples/pull/9#pullrequestreview-1114950044

secretshardul avatar Sep 21 '22 09:09 secretshardul

I don't think that we need our permission. However, for a recommendation, I think that https://github.com/vercel/next.js/tree/canary/examples/with-material-ui's pattern would be better, to avoid the dilution of the effort.

oliviertassinari avatar Sep 21 '22 09:09 oliviertassinari

I don't think that we need our permission. However, for a recommendation, I think that https://github.com/vercel/next.js/tree/canary/examples/with-material-ui's pattern would be better, to avoid the dilution of the effort.

Agree, I don't think it's worth maintaining examples in two places. For example based on https://github.com/mui/material-ui/issues/34170 seems like our example is already outdated, and haven't to check this in two places would add unnecessary burden. Maybe just linking this example would be sufficient.

mnajdova avatar Sep 23 '22 08:09 mnajdova

This seems to be a still valid PR to be merged. Any update on this?

phoenixcoded20 avatar Feb 14 '23 06:02 phoenixcoded20

This seems to be a still valid PR to be merged. Any update on this?

@phoenixcoded20 Would you like to continue working on this PR? I guess there are some changes left.

There are multiple issues regarding Remix's example - https://github.com/mui/material-ui/issues?q=is%3Aissue+is%3Aopen+remix+label%3Aexamples. Anybody who is willing to work on them, can collaborate on this PR or feel free to create a new PR.

ZeeshanTamboli avatar Apr 13 '23 12:04 ZeeshanTamboli