material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[SnackbarUnstyled] Create component and `useSnackbar` hook

Open ZeeshanTamboli opened this issue 3 years ago • 8 comments

Part of #27170.

Also part of #31991 (Stacked snackbars). See https://github.com/mui/material-ui/pull/31991#issuecomment-1148374025.

Once merged, I will use this for Stacked snackbars as well.

Docs preview: https://deploy-preview-33227--material-ui.netlify.app/base/react-snackbar/

ZeeshanTamboli avatar Jun 20 '22 14:06 ZeeshanTamboli

Details of bundle changes

@material-ui/unstyled: parsed: +2.15% , gzip: +1.84% @mui/material-next: parsed: +0.96% , gzip: +0.84%

Generated by :no_entry_sign: dangerJS against 6cb3dad3c854fd7b15b91fbb778994994f591905

mui-bot avatar Jun 20 '22 14:06 mui-bot

I'm happy to apply the updated docs formatting to this page if we're ready for that. I just don't want to step on any toes by pushing some commits to this PR. 😁 @mnajdova @ZeeshanTamboli

mapache-salvaje avatar Aug 11 '22 14:08 mapache-salvaje

I'm happy to apply the updated docs formatting to this page if we're ready for that. I just don't want to step on any toes by pushing some commits to this PR. 😁 @mnajdova @ZeeshanTamboli

@samuelsycamore I need to revise the transition demo. I'll let you know when the docs are ready to polish up. Thanks.

ZeeshanTamboli avatar Aug 12 '22 03:08 ZeeshanTamboli

@mnajdova Ready for further code review. @samuelsycamore @danilo-leal Ready for docs polishing!

ZeeshanTamboli avatar Aug 15 '22 15:08 ZeeshanTamboli

I'm on it! 👍 I'll push some changes to this branch to apply style and formatting changes to snackbar.md to match what we've established in mui/material-ui#33156. I'll leave the rest of the PR alone.

mapache-salvaje avatar Aug 16 '22 15:08 mapache-salvaje

I've finished my draft of the documentation. @ZeeshanTamboli let me know if the info I've added is accurate!

mapache-salvaje avatar Aug 17 '22 02:08 mapache-salvaje

@ZeeshanTamboli I've revised the Introduction and expanded on the Basics section, explaining what differentiates a snackbar from other alerts, and pointing out the autoHideDuration prop. Let me know if that looks good!

I was a little hesitant to use Material Design as a source for the definition of a snackbar (since Base should theoretically be independent from MD / Material UI), but it seems like the definitive source on the topic.

mapache-salvaje avatar Aug 17 '22 18:08 mapache-salvaje

@ZeeshanTamboli I've revised the Introduction and expanded on the Basics section, explaining what differentiates a snackbar from other alerts, and pointing out the autoHideDuration prop. Let me know if that looks good!

I was a little hesitant to use Material Design as a source for the definition of a snackbar (since Base should theoretically be independent from MD / Material UI), but it seems like the definitive source on the topic.

@samuelsycamore It looks great! 👍

ZeeshanTamboli avatar Aug 18 '22 12:08 ZeeshanTamboli

Great execution @ZeeshanTamboli and sorry for the delay with the review

mnajdova avatar Oct 03 '22 07:10 mnajdova