material-ui
material-ui copied to clipboard
[SnackbarUnstyled] Create component and `useSnackbar` hook
- [x] I have followed (at least) the PR section of the contributing guide.
Part of #27170.
Also part of #31991 (Stacked snackbars). See https://github.com/mui/material-ui/pull/31991#issuecomment-1148374025.
Once merged, I will use this for Stacked snackbars as well.
Docs preview: https://deploy-preview-33227--material-ui.netlify.app/base/react-snackbar/
@material-ui/unstyled: parsed: +2.15% , gzip: +1.84% @mui/material-next: parsed: +0.96% , gzip: +0.84%
Generated by :no_entry_sign: dangerJS against 6cb3dad3c854fd7b15b91fbb778994994f591905
I'm happy to apply the updated docs formatting to this page if we're ready for that. I just don't want to step on any toes by pushing some commits to this PR. 😁 @mnajdova @ZeeshanTamboli
I'm happy to apply the updated docs formatting to this page if we're ready for that. I just don't want to step on any toes by pushing some commits to this PR. 😁 @mnajdova @ZeeshanTamboli
@samuelsycamore I need to revise the transition demo. I'll let you know when the docs are ready to polish up. Thanks.
@mnajdova Ready for further code review. @samuelsycamore @danilo-leal Ready for docs polishing!
I'm on it! 👍 I'll push some changes to this branch to apply style and formatting changes to snackbar.md to match what we've established in mui/material-ui#33156. I'll leave the rest of the PR alone.
I've finished my draft of the documentation. @ZeeshanTamboli let me know if the info I've added is accurate!
@ZeeshanTamboli I've revised the Introduction and expanded on the Basics section, explaining what differentiates a snackbar from other alerts, and pointing out the autoHideDuration prop. Let me know if that looks good!
I was a little hesitant to use Material Design as a source for the definition of a snackbar (since Base should theoretically be independent from MD / Material UI), but it seems like the definitive source on the topic.
@ZeeshanTamboli I've revised the Introduction and expanded on the Basics section, explaining what differentiates a snackbar from other alerts, and pointing out the
autoHideDurationprop. Let me know if that looks good!I was a little hesitant to use Material Design as a source for the definition of a snackbar (since Base should theoretically be independent from MD / Material UI), but it seems like the definitive source on the topic.
@samuelsycamore It looks great! 👍
Great execution @ZeeshanTamboli and sorry for the delay with the review