pythonBits icon indicating copy to clipboard operation
pythonBits copied to clipboard

Book Submissions

Open znedw opened this issue 5 years ago • 5 comments

  • Goodreads & Google Books integration working
  • Description generation working
  • Upload form untested

image

znedw avatar Oct 20 '20 05:10 znedw

Okay squashed, tested (working) and ready to review, thoughts please @mueslo?

Things I don't like:

  • pycountry package just to workout the book language from a 3 letter code, we really only need an iso-639 lookup list Goodreads gives us 'eng' and Google Books gives me 'en'. I'd rather the full-name of the language, so that's why it's here
  • Goodreads description has HTML in it, right now it's regex'd out, but we could do some html2bbcode to preserve formatting (which would be nice)
  • calibre dependency for ebook-meta, the less-nice way is to just fail gracefully and let the user input the isbn manually (which they're able to do now)
  • no Edition Note, not sure how to do this based on what Goodreads is giving me
  • tags are not so great, might need another source, there's no specific flag anywhere for fiction or non-fic and it's only sometimes in the Google Books categories
  • cover art from Google Books (as Goodreads can't/won't distribute cover art) is tiny
  • no tests

Resolves https://github.com/mueslo/pythonBits/issues/91

znedw avatar Oct 20 '20 09:10 znedw

Awesome work! I will try to look over it as soon as possible.

mueslo avatar Oct 20 '20 14:10 mueslo

Any chance to add some sort of automatic subcategorisation logic like is present for video/audio? https://github.com/mueslo/pythonBits/blob/faeb9714067a5399ab3fab414008c0218ff03404/pythonbits/bb.py#L83-L90

mueslo avatar Oct 20 '20 14:10 mueslo

Any chance to add some sort of automatic subcategorisation logic like is present for video/audio?

https://github.com/mueslo/pythonBits/blob/faeb9714067a5399ab3fab414008c0218ff03404/pythonbits/bb.py#L83-L90

Interesting, let me try and see what I can do!

znedw avatar Oct 20 '20 22:10 znedw

Goodreads API is now dead https://www.goodreads.com/api https://joealcorn.co.uk/blog/2020/goodreads-retiring-API

znedw avatar Dec 13 '20 22:12 znedw