Ettore Di Giacinto

Results 630 comments of Ettore Di Giacinto

> I'd like to advocate for a single/elected background downloader service (if not already present; it doesn't seem to be from the startup behavior I've seen so far): There is...

error looks unrelated, as it seems to hit master nonetheless. last green test on apple was from https://github.com/mudler/LocalAI/commit/5fed9c65968535309349fc3353df5fbf4f4295ca

hey @mintyleaf - sorry for coming late at this but just saw the PR (please mention me to have a review, I am a bit overwhelmed by GH notifications!) The...

Seems we can't propagate client disconnection during non-SSE requests due to https://github.com/valyala/fasthttp/issues/468 , also affects go-fiber: https://github.com/gofiber/fiber/issues/1718

just as a note, echo doesn't have such issues: https://github.com/labstack/echo/issues/1581

found an ugly workaround, but works for our case. Would be nice if fasthttp supports this natively, but I guess for now that's the only way we can tackle this.

> Hi @mudler, can you have a look at this PR and the notes for reviewers section. > Thanks Sure! will try to review today, thanks for the PR.

> > 1. Should we check if the server supports Range Header(used here for partial downloads), most modern web servers do. I think we probably should - mainly because otherwise...

> > I think we probably should - mainly because otherwise if a web server does not support it we leave a dangling `.partial` file which can't be removed, and...