MuditaOS
MuditaOS copied to clipboard
[EGD-8018] Add Danish text input
As per requested on the forum, https://forum.mudita.com/t/will-it-work-in-denmark/3271/2
Hi, thanks for contributing! We have to add a Jira ticket to your PR to be able to pass the CI checks, as right now it fails on commit check:
[bc57a2fe6ae010312f842c8329d280b20f8aef2b] invalid subject "Add Danish text input", should match format "^\[(EGD|BH|CP)-\d+\] [A-Z].+[^.]$"
Hi, thanks for contributing! We have to add a Jira ticket to your PR to be able to pass the CI checks, as right now it fails on commit check:
[bc57a2fe6ae010312f842c8329d280b20f8aef2b] invalid subject "Add Danish text input", should match format "^\[(EGD|BH|CP)-\d+\] [A-Z].+[^.]$"
If so, also update development_workflow.md to match ♥
Hi, thanks for contributing! We have to add a Jira ticket to your PR to be able to pass the CI checks, as right now it fails on commit check:
[bc57a2fe6ae010312f842c8329d280b20f8aef2b] invalid subject "Add Danish text input", should match format "^\[(EGD|BH|CP)-\d+\] [A-Z].+[^.]$"If so, also update
development_workflow.mdto match hearts
It's already there:
Commits from the community will be accompanied by a relevant Jira ticket number during the merge. Don't add commits that are out of the scope of the Jira issue you are working on. You should have exactly one commit in a single PR.
Saying so - I've created a ticket for you, so you can update the commit's name with it: EGD-8018
FYI - I've found something strange in our CI - probably temporary problem - that's why your check is "expected" EDIT: Should be fixed :)
@snan If you rebase your branch, checks should be passed ;)
@snan please squash/fix those 2 commits - I'm keeping my eye on Jenkins right now - if the error persists after this, I'll take a look at it
God damned GitHub's web interface! It pulled with merge instead of pull --rebase. I'm trying to redo the rebase locally.
God damned GitHub's web interface! It pulled with merge instead of
pull --rebase. I'm trying to redo the rebase locally.
what I did on my own fork was:
- adding
muditaorigin for fork:git remote add-url mudita URL_HERE - fetching the "original" repo:
git fetch mudita - rebasing to the main repo:
git rebase mudita/master -i - pushing rebased branch to fork's origin:
git push origin branch -f
Maybe it will help you with this and future rebases - it's simpler and quicker in my opinion ;)
@snan if you'll encounter more problems with this rebase you can always reach me via PM on our forum ;)
@snan FYI you've made a typo :P EDG should be EGD ;)