Nick Mudge

Great to see this!

Thanks @fulldecent Good point. Will consider this.

Hey @Walodja1987, thanks for making an issue about this. Let's get to the bottom of it. It should work fine in a facet. delegatecall is okay for this. Where is...

Hey, sorry, looking now.

@Walodja1987 thanks for this. Where's your migration script? For example like this: https://github.com/mudgen/diamond-1/blob/master/migrations/2_diamond.js

@Walodja1987 Thank you. One thing that stuck out at me is this line: `const OptionFacet = artifacts.require('OptionFacet.sol')` Should it instead be: `const OptionFacet = artifacts.require('OptionFacet')` ? If you add another...

Great you are making progress. It does work, but you can't use state variables declared like `b` in proxy contracts and diamonds. You need to use diamond storage or AppStorage...

@divaprotocol Okay, I'm not sure what the problem is but it is possible to create new contracts (include ERC20) from within facets in diamonds. It is done successfully here: https://github.com/aavegotchi/aavegotchi-contracts/blob/cbb90bce8a1ef047b376ce7e388ca1c81ac48e00/contracts/Aavegotchi/facets/AavegotchiFacet.sol#L235...

@divaprotocol Yes, maybe try creating a new but very simple contract that isn't ERC20 and see if that works.

@divaprotocol There isn't a maximum number of functions you can have. But there is a maximum number of bytes the bytecode of your contract can be which is about 24KB....