FastAPI-JSONAPI icon indicating copy to clipboard operation
FastAPI-JSONAPI copied to clipboard

fix for custom fields for includes (many-to-one direction)

Open srepmub opened this issue 6 months ago • 7 comments

by passing missing include_fields parameter.

fixes issue #101 for me.

srepmub avatar May 20 '25 09:05 srepmub

@srepmub thank you for your PR. Please fix the formatting and order of the 'included' in the tests. After that, the changes can be merged into the main branch.

m-antonov avatar May 21 '25 09:05 m-antonov

not entirely sure what you mean, but how about this..? (user1 and user2 are already in the right order though it seems?)

srepmub avatar May 22 '25 13:05 srepmub

fix a formatting issue.

srepmub avatar May 23 '25 13:05 srepmub

not sure why 'black' insists on putting certain things on a single line, but not similar code elsewhere. another attempt :P

srepmub avatar May 26 '25 08:05 srepmub

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.44%. Comparing base (a1a4fc5) to head (ad7bc3a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files          44       44           
  Lines        2408     2408           
  Branches      279      279           
=======================================
  Hits         2202     2202           
  Misses        143      143           
  Partials       63       63           
Flag Coverage Δ
unittests 91.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
fastapi_jsonapi/views/view_base.py 93.05% <100.00%> (ø)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 30 '25 11:05 codecov[bot]

okay now 'ruff' fails.. will try to fix

srepmub avatar Jun 26 '25 07:06 srepmub

sorry for the delay. hope everything passes now.

srepmub avatar Jun 26 '25 09:06 srepmub