Matt Fishman

Results 497 comments of Matt Fishman

Regarding the data structure used in the `svd_bond_coefs(...)` function: > This could be a `DataGraph` with that data on the edges of the graph. > > I also wonder if...

Can this be closed in favor of #160?

> > Can this be closed in favor of #160? > > I suggest keeping them separate and removing the randomized SVD related code in #160 , since they are...

Yeah, definitely something we need. Though it should be called `random_ttn` to follow the convention that only types (and constructors with the exact name of the type) are capitalized. Also,...

Sorry for the very long delay in reviewing this, finally finding some time to take a look. In terms of the API, instead of the `partitioned_contract` you propose above, what...

Yeah, we should come up with a better name for that functionality, or just use `ITensorNetwork` there. Functions that are the same name as a type (and with the same...

You should be able to just use `Vector{ITensor}` or `collect`, those are the standard ways to get a `Vector` of a certain type of object.

If those don't work for certain objects (like `Vector{ITensor}(::ITensorNetwork)`) then we should make them work.

Yes, I think we should remove any automated index replacement and leave it up to the user to provide a proper `init_state`. ~~For example, it doesn't make sense to try...