Matt Fishman

Results 482 comments of Matt Fishman

Hi @nlw0, sorry for the slow response on this. I think it would help to have an explanation of the equations that different steps of the code are trying to...

I think better names for this could be `eachindex` to match with Julia's usage of `index` or `eachval` to match with the ITensor usage of `val` as a value an...

Really cool, thanks @GiggleLiu! I have been interested in the development of `OMEinsumContractionOrders.jl`, it is great to have these modern contraction sequence optimization algorithms available in Julia. Nice to hear...

Sorry for the slow response about this @GiggleLiu. I've made a repository here: https://github.com/mtfishman/ITensorContractionSequences.jl. Could you move the PR there?

Thanks @markusschmitt. My major concern here would be ensuring that by truncating in this way the orthogonality center is still at site `1`. Would you mind checking that?

If it does turn out to be an issue, a simple fix would be to determine at what site the orthogonality gets broken (say site `n`), set the orthogonality center...

@dylex do you know why the Jenkins test failed here? I've been seeing occasional errors, can we just increase the `timeout` time?

> I thought I fixed this but maybe it's still not right. I'll take a closer look. In the mean time I manually re-ran the test and now it's failing...

> If you register a user on jenkins I can add you to be able to trigger builds. That would be great, thanks. I just registered with the User ID...

Thanks for the report @oskar-leimkuhler! Should be a simple fix.