Michael Vernik

Results 8 comments of Michael Vernik

Hello, the nginx-otel module does have some 3rd-party dependencies and needs to be compiled separately using cmake, as described in the README.

The dependencies are on 3rd-party opentelemetry code. They're pulled and compiled into the module during the build process. Here's the particular example you're referring to: https://github.com/nginxinc/nginx-otel/blob/main/CMakeLists.txt#L37

Hello, those are 3rd-party dependency libraries that will need to be installed or built from source. The README contains [instructions](https://github.com/nginxinc/nginx-otel?tab=readme-ov-file#building) for installing these libraries on Ubuntu/Debian systems. You will need...

@royteeuwen can you clarify? We don't distribute 3rd-party dependencies. They can be installed via apt/yum directly from the 3rd parties. We provide a list in the README: ```console sudo apt...

Wanted to check in on what was decided in regards to the message index. I had proposed that we use millis since epoch or timestamp vs (or in addition to?)...

> @mtbChef we already have a LICENSE file. See my pull request #112 where I move it to the project root. Yep, I moved it to the project root too...

> After merging #112 we already have a `LICENSE` at root, so it can be removed from this PR. This will resolve the conflict as well. Also, currently we have...

> Helpful, but why touch makefile To follow the .md extension standard