technic
technic copied to clipboard
mt-mods
Mining Drill Breaks Unbreakable Items
The mining drills provided by this mod are able to break normally unbreakable blocks, such as default:cloud.
Should be simple enough to fix
Relevant code: https://github.com/mt-mods/technic/blob/ec3a52c668ec6786e925e197fc01d75bb7f5bb93/technic/tools/mining_drill.lua#L49-L65
Looks like there is basically just a hardcoded blacklist :confounded:
Parts of the quarry-code could be used to replace that, or even shared globally: https://github.com/mt-mods/technic/blob/ec3a52c668ec6786e925e197fc01d75bb7f5bb93/technic/machines/HV/quarry.lua#L172-L184
EDIT: the vacuum:vacuum node check is redundant btw, the node-def already has diggable = false on it
Not sure if this could be a feature-bug or not, probably better to fix it though. (I wonder if it might be good to add fixes for other feature-bugs with a setting to allow them)
Looks like there is basically just a hardcoded blacklist 😖
Yep, the drills haven't gotten a rewrite yet :)
EDIT: the vacuum:vacuum node check is redundant btw, the node-def already has diggable = false on it
That was just a minor optimization for the quarry. (no clue if it actually makes any significant difference)
Can we just use the code from the quarry for the drill? It looks like it would work better, since it's less hardcoded.
Can we just use the code from the quarry for the drill? It looks like it would work better, since it's less hardcoded.
Sure, that's the plan, no one is working on that currently so if you want to try that, go ahead :+1:
no one is working on that currently
Not on that exact issue but I would still request minimal changes to avoid big conflicts with #233 Or I could finish that one quickly and fork all mods that have not accepted PR to mt-mods org.
There's just one PR I've added few days ago and promised to add another optional PR soon after. not done that yet but I do have code available that should be fine.
