Michael Seibt

Results 207 comments of Michael Seibt
trafficstars

A user install of .NET might be an alternative solution: refer to #12181. How much larger does the portable GE become with the self-contained .NET runtime?

> Not understanding exit codes as non errors is a failure on executable handling. Which of these exit codes is not an error for `string GetEffectiveGitSetting(...)`? None. If you need...

Again, if you need a **Try**Get, implement one. If the error from the `Get` function is not clear enough, it can be improved. Users of `GetEffectiveGitSetting(...)` expect the existence of...

What is unclear with ``` Exit code: 1 Command: C:\Program Files\Git\bin\git.exe Arguments: config --includes --get cat.dog Working directory: C:\git\gitextensions\ ``` ? What you want, is a `TryGet`. But you call...

> allows for exceptional handling **if needed** That is the same error-hiding attitude as `.ExitCode ?? 0`. What if one "forgets" to evaluate the provided status? > prevent users reporting...

Again: `Get` presumes that the value _is_ set. You want a different function. Then emphasize that it can fail without throwing an exception. That's why `TryGet`.