msvc-wine icon indicating copy to clipboard operation
msvc-wine copied to clipboard
verified publisher icon mstorsjo

LLVM DIA SDK

Open yuanfang-chen opened this issue 3 years ago • 2 comments

LLVM DIA SDK support seems to need the ATL package ("Microsoft.VisualStudio.Component.VC.ATL"). Add it to the default package since DIA SDK is included already?

https://github.com/llvm/llvm-project/blob/7ee1c162cc53d37f717f9a138276ad64fa6863bc/llvm/include/llvm/DebugInfo/PDB/DIA/DIASupport.h#L25

yuanfang-chen avatar Jan 21 '22 04:01 yuanfang-chen

Thanks, you're right that I hadn't really tried out the DIA SDK support here.

I pushed an experimental branch here, at https://github.com/mstorsjo/msvc-wine/commit/atl, which installs this package too. I think this seems to work for building LLVM with DIA SDK enabled.

I guess if we do this, we should also add this package consistently to the versioned install targets, if installing with e.g. --msvc-16.3 - what do you think?

mstorsjo avatar Jan 21 '22 15:01 mstorsjo

Thanks, you're right that I hadn't really tried out the DIA SDK support here.

I pushed an experimental branch here, at atl, which installs this package too. I think this seems to work for building LLVM with DIA SDK enabled.

I guess if we do this, we should also add this package consistently to the versioned install targets, if installing with e.g. --msvc-16.3 - what do you think?

Thanks a lot for the quick response. Yeah, I think it makes sense to add ATL to the versioned install targets.

yuanfang-chen avatar Jan 21 '22 18:01 yuanfang-chen